[ 
https://issues.apache.org/jira/browse/HBASE-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705114#action_12705114
 ] 

Shalin Shekhar Mangar commented on HBASE-1192:
----------------------------------------------

Can someone elaborate on why a custom implementation of an LRUCache is being 
made? I guess you can achieve memory-awareness by extending or wrapping a 
LinkedHashMap.

Also, is the synchronized get/put alright for this use-case? Solr had some 
issues with synchronized LRUCache when the cache was hit thousands of times per 
second. SOLR-667 has a good implementation that you can look at.

I do not have the complete background so I may have missed something.

> LRU-style map for the block cache
> ---------------------------------
>
>                 Key: HBASE-1192
>                 URL: https://issues.apache.org/jira/browse/HBASE-1192
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: regionserver
>            Reporter: Jonathan Gray
>            Assignee: ryan rawson
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: hbase-1192-v1.patch, hbase-1192-v2.patch, 
> hbase-1192-v3.patch
>
>
> We need to decide what structure to use to back the block cache.  The primary 
> decision is whether to continue using SoftReferences or to build our own 
> structure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to