[
https://issues.apache.org/jira/browse/HBASE-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706721#action_12706721
]
stack commented on HBASE-1382:
------------------------------
Is this in wrong place in HConstants? Seems after when it should be before:
{code}
+ //
+ // New stuff. Making a slow transition.
+ //
+
+
{code}
Your style is a little odd. In below your (lack-of) spacing is different from
rest of hbase/hadoop style. You do this:
{code}
+ this.bytes = createByteArray(row,0,rlength,column,0,clength,
{code}
Then in line above the one above, you put spaces around everything.
This is another (unreadable) example:
{code}
+ this(row,0,row==null?0:row.length,family,0,family==null?0:family.length,
{code}
Add class javadoc to SplitKeyValue.
Is this a regression?
{code}
- return kv.matchingColumnNoDelimiter(this.col, this.familylength);
+ return kv.matchingColumnNoDelimiter(this.col);
{code}
The passed column has a delimiter or not? Doesn't? Need to know where its
offset is?
This belongs in KV I think rather than Bytes.... no need of polluting Bytes
with KV and column stuff: parseColumn
Otherwise, patch looks great. Passes tests?
> Rework KeyValue to primarily act on split columns rather than colon delimited
> -----------------------------------------------------------------------------
>
> Key: HBASE-1382
> URL: https://issues.apache.org/jira/browse/HBASE-1382
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.20.0
>
> Attachments: hbase-1382-v1.patch
>
>
> Right now, KeyValue only supports family:qualifier notation for building
> KeyValues.
> This issue will retain some of that, but will move to primarily supporting
> family and qualifier as separate arguments. Methods that use a delimited
> column will detect the delimiter and use the split implementations behind the
> scenes.
> Not sure whether this will be remain exclusive to KeyValue yet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
