Threads.shutdown has unnecessary branch
---------------------------------------
Key: HBASE-1405
URL: https://issues.apache.org/jira/browse/HBASE-1405
Project: Hadoop HBase
Issue Type: Improvement
Reporter: Nitay Joffe
Priority: Minor
Fix For: 0.20.0
{code}
if (joinwait == -1) {
t.join();
} else {
t.join(joinwait);
}
{code}
We don't need to use -1 as a special value, as join already has a special value
of 0:
>From Thread.join() javadoc:
"Waits at most millis milliseconds for this thread to die. A timeout of 0 means
to wait forever."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.