[
https://issues.apache.org/jira/browse/HBASE-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709883#action_12709883
]
Erik Holstad commented on HBASE-1304:
-------------------------------------
@Stack
Are you mocking the test :)
I just think it is better to test the individual parts not a part of a cluster
setup, and start up the cluster where you have a test that actually deals with
sending data between the client and the server. Running all the unit test for
HBase takes quite some time and I think that depends a little on that we are
starting the clusters even though in some cases they are not needed to test the
individual units, so just trying to keep testing time to a minimum, but that
can of course be changed if you want to do it differently.
The print boolean is basically to not output any info when you have the test
working, but will change to use the logger instead.
What is weird with the names?
The reason that the Scanner in the test takes a list of KeyValues is that at
the time when the test was written there were no implementation of that
scanner, so I had to create a private class to test the KeyValueHeap, so the
way that inserting into the private test Scanner has really nothing to do with
how it is going to look in the real scanner.
> New client server implementation of how gets and puts are handled.
> -------------------------------------------------------------------
>
> Key: HBASE-1304
> URL: https://issues.apache.org/jira/browse/HBASE-1304
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.0
> Reporter: Erik Holstad
> Assignee: Jonathan Gray
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: hbase-1304-v1.patch, HBASE-1304-v2.patch,
> HBASE-1304-v3.patch, HBASE-1304-v4.patch, HBASE-1304-v5.patch,
> HBASE-1304-v6.patch
>
>
> Creating an issue where the implementation of the new client and server will
> go. Leaving HBASE-1249 as a discussion forum and will put code and patches
> here.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
