[
https://issues.apache.org/jira/browse/HBASE-1386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack resolved HBASE-1386.
--------------------------
Resolution: Fixed
Committed to branch and trunk following:
{code}
Index: src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
===================================================================
--- src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
(revision 776038)
+++ src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
(working copy)
@@ -1388,11 +1388,10 @@
* Data structure to hold a HMsg and retries count.
*/
private static final class ToDoEntry {
- protected volatile int tries;
+ protected final AtomicInteger tries = new AtomicInteger(0);
protected final HMsg msg;
ToDoEntry(final HMsg msg) {
- this.tries = 0;
this.msg = msg;
}
}
@@ -1487,9 +1486,9 @@
if (ex instanceof IOException) {
ex = RemoteExceptionHandler.checkIOException((IOException) ex);
}
- if(e != null && e.tries < numRetries) {
+ if(e != null && e.tries.get() < numRetries) {
LOG.warn(ex);
- e.tries++;
+ e.tries.incrementAndGet();
try {
toDo.put(e);
} catch (InterruptedException ie) {
{code}
> NPE in housekeeping
> -------------------
>
> Key: HBASE-1386
> URL: https://issues.apache.org/jira/browse/HBASE-1386
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.20.0
>
>
> Two regionservers hosting thousands of regions. One went down. Other was
> trying to open about 1000 regions and got this:
> {code}
> 2009-05-07 10:24:59,995 [regionserver/0:0:0:0:0:0:0:0:60021.worker] INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer: Worker: MSG_REGION_OPEN:
> REGION => {NAME => 'TestTable,1094797576,1241684896885', STARTKEY =>
> '1094797576', ENDKEY => '1096819542', ENCOD
> ED => 1333893125, TABLE => {{NAME => 'TestTable', FAMILIES => [{NAME =>
> 'info', COMPRESSION => 'NONE', VERSIONS => '3', LENGTH => '2147483647', TTL
> => '-1', BLOCKSIZE => '65536', IN_MEMORY => 'false', BLOCKCACHE => 'false'}]}}
> 2009-05-07 10:24:59,996 [regionserver/0:0:0:0:0:0:0:0:60021] FATAL
> org.apache.hadoop.hbase.regionserver.HRegionServer: Unhandled exception.
> Aborting...
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.housekeeping(HRegionServer.java:1141)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:518)
> at java.lang.Thread.run(Thread.java:619)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
