[ 
https://issues.apache.org/jira/browse/HBASE-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Evgeny Ryabitskiy updated HBASE-1480:
-------------------------------------

    Attachment: HBASE-1480.patch

There was a bug in Cleaning up for HRegions.
Each time at beginning and end of Compaction HRegion deletes 
regionCompactionDir in FS for clean up.

Name of regionCompactionDir is computed this way :

{code}
this.regionCompactionDir =  new Path(getCompactionDir(basedir), encodedNameStr);

Ex.:  hbase/myTable/compaction.dir/23143254
{code}

But! Stores for this HRegion create and use compactionDir, with name computed 
this way:

{code}
this.compactionDir = getCompactionDir(basedir);

Ex.:  hbase/myTable/compaction.dir
{code}

Diff in sub dir for each HRegion with encodedNameStr

So I changed dir where Stores put compaction files. Now compactions for Each 
Stores are stored separately in FS and clean up performed each time compaction 
starts and ends.


*Last one note about migration:*

*No one file should be stored in upper compactionDir (they should be stored in 
subdirs, regionCompactionDirs). So we need to clean up all compactionDirs for 
all Table dirs in FS during migration*

> compaction file not cleaned up after a crash/OOME server
> --------------------------------------------------------
>
>                 Key: HBASE-1480
>                 URL: https://issues.apache.org/jira/browse/HBASE-1480
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: master, regionserver
>            Reporter: Billy Pearson
>            Assignee: Evgeny Ryabitskiy
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1480.patch
>
>
> We do not clean up compaction files after a crash/OOME of a region server.
> I am not sure how the compaction file naming is anymore if its not 
> reproducable some how we 
> should let the master or the server with the root region check every so often 
> and delete old files say 
> older then 24 hours in the compaction dir's of the tables

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to