[
https://issues.apache.org/jira/browse/HBASE-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719170#action_12719170
]
stack commented on HBASE-1495:
------------------------------
Excellent Ryan. Testing now.
Comments on patch:
Why remove this:
{code}
- LOG.debug(location);
{code}
IIRC, its useful emitting when region when its added cache... some hope of
figuring whats going on client-side?
The half-file reader fix looks great.
Don't commit the System.out.printlns
You do this:
{code}
- this.row = row;
{code}
Is that right?
Patch mixes in compacting fix but thats fine.
Patch looks good.
Trying it now.
> IllegalArgumentException in halfhfilereader#next
> ------------------------------------------------
>
> Key: HBASE-1495
> URL: https://issues.apache.org/jira/browse/HBASE-1495
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Fix For: 0.20.0
>
> Attachments: 1495.patch, HBASE-1495.patch, HBASE-1495.patch
>
>
> From posix4e up on IRC
> {code}
> #
> 2009-06-07 20:22:33,367 ERROR
> org.apache.hadoop.hbase.regionserver.CompactSplitThread: Compaction failed
> for region t3,*******************,1244420117045
> #
> java.lang.IllegalArgumentException
> #
> at java.nio.Buffer.position(Buffer.java:218)
> #
> at
> org.apache.hadoop.hbase.io.hfile.HFile$Reader$Scanner.next(HFile.java:1072)
> #
> at
> org.apache.hadoop.hbase.io.HalfHFileReader$1.next(HalfHFileReader.java:108)
> #
> at
> org.apache.hadoop.hbase.regionserver.StoreFileScanner.next(StoreFileScanner.java:52)
> #
> at
> org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:79)
> #
> at
> org.apache.hadoop.hbase.regionserver.MinorCompactingStoreScanner.next(MinorCompactingSto
> #
> reScanner.java:101)
> #
> at org.apache.hadoop.hbase.regionserver.Store.compact(Store.java:849)
> #
> at org.apache.hadoop.hbase.regionserver.Store.compact(Store.java:714)
> #
> at
> org.apache.hadoop.hbase.regionserver.HRegion.compactStores(HRegion.java:766)
> #
> at
> org.apache.hadoop.hbase.regionserver.HRegion.compactStores(HRegion.java:723)
> #
> at
> org.apache.hadoop.hbase.regionserver.CompactSplitThread.run(CompactSplitThread.java:105)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
