[jira] Issue Comment Edited: (HBASE-1507) iCMS as default JVM

[ryan rawson (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719225#action_12719225
 ] 

ryan rawson edited comment on HBASE-1507 at 6/13/09 9:44 PM:
-------------------------------------------------------------

I agree, the config should be in hbase-env.sh since tuning the GC is a fairly 
frequent activity.

Here is my proposed patch different:

{{index 81d5e10..1101217 100755
--- a/bin/hbase
+++ b/bin/hbase
@@ -206,7 +206,7 @@ fi
 # and are named like the following: java_pid21612.hprof. Apparently it doesn't
 # 'cost' to have this flag enabled. Its a 1.6 flag only. See:
 # http://blogs.sun.com/alanb/entry/outofmemoryerror_looks_a_bit_better
-HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError 
-XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError"
 HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
 HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
 HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
diff --git a/conf/hbase-env.sh b/conf/hbase-env.sh
index 352cb2c..92f57d4 100644
--- a/conf/hbase-env.sh
+++ b/conf/hbase-env.sh
@@ -33,7 +33,7 @@
 # Extra Java runtime options.
 # Below are what we set by default.  For more on why as well as other possible
 # settings, see http://wiki.apache.org/hadoop/PerformanceTuning
-# export HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError 
-XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+export HBASE_OPTS="$HBASE_OPTS -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
 
 # File naming hosts on which HRegionServers will run.  
$HBASE_HOME/conf/regionservers by default.
 # export HBASE_REGIONSERVERS=${HBASE_HOME}/conf/regionservers}}

      was (Author: ryanobjc):
    I agree, the config should be in hbase-env.sh since tuning the GC is a 
fairly frequent activity.

Here is my proposed patch different:

index 81d5e10..1101217 100755
--- a/bin/hbase
+++ b/bin/hbase
@@ -206,7 +206,7 @@ fi
 # and are named like the following: java_pid21612.hprof. Apparently it doesn't
 # 'cost' to have this flag enabled. Its a 1.6 flag only. See:
 # http://blogs.sun.com/alanb/entry/outofmemoryerror_looks_a_bit_better
-HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError 
-XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError"
 HBASE_OPTS="$HBASE_OPTS -Dhbase.log.dir=$HBASE_LOG_DIR"
 HBASE_OPTS="$HBASE_OPTS -Dhbase.log.file=$HBASE_LOGFILE"
 HBASE_OPTS="$HBASE_OPTS -Dhbase.home.dir=$HBASE_HOME"
diff --git a/conf/hbase-env.sh b/conf/hbase-env.sh
index 352cb2c..92f57d4 100644
--- a/conf/hbase-env.sh
+++ b/conf/hbase-env.sh
@@ -33,7 +33,7 @@
 # Extra Java runtime options.
 # Below are what we set by default.  For more on why as well as other possible
 # settings, see http://wiki.apache.org/hadoop/PerformanceTuning
-# export HBASE_OPTS="$HBASE_OPTS -XX:+HeapDumpOnOutOfMemoryError 
-XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
+export HBASE_OPTS="$HBASE_OPTS -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode"
 
 # File naming hosts on which HRegionServers will run.  
$HBASE_HOME/conf/regionservers by default.
 # export HBASE_REGIONSERVERS=${HBASE_HOME}/conf/regionservers
  
> iCMS as default JVM
> -------------------
>
>                 Key: HBASE-1507
>                 URL: https://issues.apache.org/jira/browse/HBASE-1507
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.20.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.