[
https://issues.apache.org/jira/browse/HBASE-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721665#action_12721665
]
stack commented on HBASE-1387:
------------------------------
Looks great Erik
Why define sizes in ClassSize and not use HeapSize or Bytes defines?
You do this 'for(int i=0' sometimes -- i.e. no space around '=' and then
elsewhere you do have space (no biggie -- just pointing it out)
Is there an align in Bytes? I think jgray added it there not too long ago.
Is this comment in TestHeapSize right?
+ // List of classes implementing HeapSize, some missing
+ // BatchOperation, BatchUpdate, BlockIndex, Entry, Entry<K,V>, HStoreKey
+ // KeyValue, LruBlockCache, LruHashMap<K,V>, Put
What classes are missing from TestHeapSize?
Do you manage to get sizeof running and compare its findings to yours?
> Before release verify all object sizes using Ryans' instrumented JVM trick
> --------------------------------------------------------------------------
>
> Key: HBASE-1387
> URL: https://issues.apache.org/jira/browse/HBASE-1387
> Project: Hadoop HBase
> Issue Type: Task
> Reporter: stack
> Assignee: Erik Holstad
> Fix For: 0.20.0
>
> Attachments: HBASE-1387-v1.patch, HBASE-1387-v2.patch,
> HBASE-1387-v3.patch, HBASE-1387-v4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
