[ 
https://issues.apache.org/jira/browse/HBASE-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitay Joffe updated HBASE-1515:
-------------------------------

    Attachment: hbase-1515.patch

Yes, I agree with Ryan. In fact, if you look at the code currently we already 
have the options hbase.regionserver.dns.interface/nameserver. These are used by 
the info server that an RS brings up, yet the address is used by the RS itself.

Attaching a patch that fixes things, in particular:
# conf/hbase-default.xml:
## Remove 'hbase.regionserver', add 'hbase.regionserver.port'
# HConstants.java:
## Constants for changes above.
## Constant for master port to clean up use of string in various places.
# LocalHBaseCluster.java:
## Set port to 0 instead of entire address.
# HMaster.java:
## Cleanups of port constant and fix usage message.
# HRegionServer.java:
## Fold two constructors into one, like with HMaster.
## Lookup address to bind to using Hadoop style DNS query, just like HMaster.
## Remove bind option from main(), like we did with master.
# MiniHBaseCluster.java:
## Use constants for common master port string lookup.
# OOMERegionServer
## Remove unused constructor.

> Address part of config option hbase.regionserver unnecessary
> ------------------------------------------------------------
>
>                 Key: HBASE-1515
>                 URL: https://issues.apache.org/jira/browse/HBASE-1515
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Nitay Joffe
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: hbase-1515.patch
>
>
> We have a configuration option "hbase.regionserver" that specifies address + 
> port the region servers should bind to. I believe all of our users don't 
> require the address part of it and always leave it as 0.0.0.0. Most people 
> rsync their configs to all the machines in the cluster, so anything other 
> than 0.0.0.0 doesn't really make sense.
> We should change this option into just hbase.regionserver.port, like we have 
> with the master now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to