[ 
https://issues.apache.org/jira/browse/HBASE-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726747#action_12726747
 ] 

stack commented on HBASE-1607:
------------------------------

Remove rather than comment out stuff.

Is ClassSize utility to estimate a Class size or instance of a Class size?  If 
latter, should be renamed.

All these DEEP_OVERHEAD and FIXED_OVERHEAD defines make me nervous.  Would seem 
to be very brittle and hard to make changes.  Where are they used?  In test 
only?











> Redo MemStore heap sizing to be accurate, testable, and more like new 
> LruBlockCache
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-1607
>                 URL: https://issues.apache.org/jira/browse/HBASE-1607
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1607-v1.patch
>
>
> MemStore sizing is inaccurate and does not include all overhead.
> I'm going to make it look like the LruBlockCache does.  Will provide a 
> MemStore.heapSize() method that includes ALL overhead of the MemStore itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to