[ 
https://issues.apache.org/jira/browse/HBASE-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728341#action_12728341
 ] 

Jean-Daniel Cryans commented on HBASE-698:
------------------------------------------

bq. I wonder why the code in BaseScanner was insufficient? 

It was reacting only when seeing stale data in META or ROOT so if you lost an 
edit in META, you won't see it back in BaseScanner. I think BaseScanner never 
recovered anything ever because we don't have appends. Now we will have the 
issue of recovering regions without a META entry tho...

bq. So, j-d, why not mod BaseScanner to check zk rather than do the filesystem 
check? Filesystem check is more comprehensive?

ZK won't tell you about dead region servers, only the live ones.

> HLog recovery is not performed after master failure
> ---------------------------------------------------
>
>                 Key: HBASE-698
>                 URL: https://issues.apache.org/jira/browse/HBASE-698
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: master, regionserver
>    Affects Versions: 0.1.2
>            Reporter: Clint Morgan
>            Assignee: Jean-Daniel Cryans
>            Priority: Blocker
>             Fix For: 0.20.0
>
>         Attachments: hbase-698.patch
>
>
> I have a local cluster running, and its logging to
> <hbase>/log_X.X.X.X_1213228101021_60020/
> Then I kill both master and regionserver, and restart. Looking through
> the logs I don't see anything about trying to recover from this hlog,
> it just creates a new hlog alongside the existing one (with a new
> startcode).  The older hlog seems to be ignored, and the tables
> created in the inital session are all gone.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to