[
https://issues.apache.org/jira/browse/HBASE-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728699#action_12728699
]
Lars George commented on HBASE-1626:
------------------------------------
Oops looking at the IdentityTableReducer, I think the issue is it has the same
bug I had in my own classes, i.e. missing the @Override on the "reduce()" and
hence missing it is not used at all! Means that I think the reason for Doğacan
to extend the classes was that the expected results did not work. I'll attach a
patch to fix in the existing mapreduce code, please apply that first before
applying the generics patch.
Also, while the key is not used, users could still extend our classes and make
use of it, so not sure why touch it or not. If you leave TableReduce generic
then there is really no need for it anymore. It could be left as this?
{code}
public abstract class TableReducer<KEYIN, VALUEIN>
extends Reducer<KEYIN, VALUEIN, ImmutableBytesWritable, Writable> {
{code}
Then defining a reducer class
{code}
public class IdentityTableReducer
extends TableReducer<ImmutableBytesWritable, Writable> {
{code}
You have still Put's in there, so I guess that should also be change to be
Writables?
> Allow emitting Deletes out of new TableReducer
> ----------------------------------------------
>
> Key: HBASE-1626
> URL: https://issues.apache.org/jira/browse/HBASE-1626
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Lars George
> Fix For: 0.20.0
>
> Attachments: deletes.patch, table-reduce.patch
>
>
> Doğacan Güney (nutch) wants to emit Delete from TableReduce. Currently we
> only do Put.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
