[
https://issues.apache.org/jira/browse/HBASE-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728842#action_12728842
]
Jonathan Gray commented on HBASE-1626:
--------------------------------------
Can we add more documentation / class comments / etc?
Our TableReduce now just takes a Writable but there's not really any
documentation in the class about what the intent is / how it should be used.
We ignore Key in both Map input and Reduce output? If so, let's advertise that
in javadocs all over the place. Our comments are super generic but our
usage/implementation is not generic.
We just need to be explicit and verbose in the comments about how this should
be used.
For example:
{noformat}
+ * Writes the reducer output to an HBase table.
+ *
+ * @param <KEY> The type of the key.
{noformat}
This KEY is actually not used for anything, anywhere. Why don't we say that?
Are there actually cases it could be used?
And we don't make mention that the output Value is fixed as a Writable, and
that this Writable must be either a Put or Delete.
Comments aside, I think the patch is good. Base class for Put/Delete would be
more explicit, but easier to just use Writable with lots of javadoc.
> Allow emitting Deletes out of new TableReducer
> ----------------------------------------------
>
> Key: HBASE-1626
> URL: https://issues.apache.org/jira/browse/HBASE-1626
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Lars George
> Fix For: 0.20.0
>
> Attachments: 1626-v2.patch, 1626-v3.patch, 1626-v4.patch,
> 1626-v5.patch, 1626-v6.patch, 1626.patch, deletes.patch, reducer.patch,
> table-reduce.patch
>
>
> Doğacan Güney (nutch) wants to emit Delete from TableReduce. Currently we
> only do Put.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
