[
https://issues.apache.org/jira/browse/HBASE-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729032#action_12729032
]
stack commented on HBASE-1630:
------------------------------
@Nitay
You don't want to group your HBASE_OPTS addition with original HBASE_OPTS?
Otherwise it might not be seen or worse, fellas would do as instructed,
uncomment it after making changes on first HBASE_OPTS line and then wonder why
first edit is having no effect. Do something like the below?
{code}
Index: conf/hbase-env.sh
===================================================================
--- conf/hbase-env.sh (revision 792384)
+++ conf/hbase-env.sh (working copy)
@@ -34,10 +34,9 @@
# Below are what we set by default. May only work with SUN JVM.
# For more on why as well as other possible settings,
# see http://wiki.apache.org/hadoop/PerformanceTuning
-export HBASE_OPTS="-XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC
-XX:+CMSIncrementalMode"
-
# Uncomment below to enable java garbage collection logging.
#export HBASE_OPTS="$HBASE_OPTS -verbose:gc -XX:+PrintGCDetails
-XX:+PrintGCTimeStamps -Xloggc:$HBASE_HOME/logs/gc-hbase.log"
+export HBASE_OPTS="-XX:+HeapDumpOnOutOfMemoryError -XX:+UseConcMarkSweepGC
-XX:+CMSIncrementalMode"
# File naming hosts on which HRegionServers will run.
$HBASE_HOME/conf/regionservers by default.
# export HBASE_REGIONSERVERS=${HBASE_HOME}/conf/regionservers
{code}
> Provide sample config options to enable GC debugging
> ----------------------------------------------------
>
> Key: HBASE-1630
> URL: https://issues.apache.org/jira/browse/HBASE-1630
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: scripts
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: hbase-1630.patch
>
>
> We should add a sample set of config options to HBASE_OPTS to show how to
> enable GC logging to hbase-env.sh.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.