[
https://issues.apache.org/jira/browse/HBASE-1534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12736877#action_12736877
]
Nitay Joffe commented on HBASE-1534:
------------------------------------
Wouldn't the NPE still occur, even with this patch?
{noformat}
- init(reportForDuty());
+ MapWritable w = null;
+ while (!stopRequested.get()) {
+ w = reportForDuty();
+ if (w != null) break;
+ sleeper.sleep();
+ LOG.warn("No response from master on reportForDuty. Sleeping and " +
+ "then trying again.");
+ }
+ init(w);
{noformat}
Say stopRequested is true. Then we end up calling init(w) with w = null, which
leads to the NPE?
> Got ZooKeeper event, state: Disconnected on HRS and then NPE on reinit
> ----------------------------------------------------------------------
>
> Key: HBASE-1534
> URL: https://issues.apache.org/jira/browse/HBASE-1534
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: Nitay Joffe
> Fix For: 0.20.0
>
> Attachments: 1534-redux.patch, hbase-1534-v2.patch, hbase-1534.patch
>
>
> We got disconnect from zk but then when we tried to reinitialize ourselves,
> got a NPE. See below.
> {code}
> 2009-06-17 11:58:55,102 [Thread-16] INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer: Starting shutdown thread.
> 2009-06-17 11:58:55,102 [Thread-16] INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer: Shutdown thread complete
> 2009-06-17 11:58:55,102 [main-EventThread] INFO
> org.apache.hadoop.hbase.ipc.HBaseRpcMetrics: Initializing RPC Metrics with
> hostName=HRegionServer, port=60021
> 2009-06-17 11:58:55,103 [main-EventThread] INFO
> org.apache.hadoop.hbase.regionserver.MemcacheFlusher:
> globalMemcacheLimit=556.7m, globalMemcacheLimitLowMark=347.9m, maxHeap=1.4g
> 2009-06-17 11:58:55,103 [main-EventThread] INFO
> org.apache.hadoop.hbase.regionserver.HRegionServer: Runs every 10000000ms
> 2009-06-17 11:58:55,148 [regionserver/0:0:0:0:0:0:0:0:60021] ERROR
> org.apache.hadoop.hbase.regionserver.HRegionServer: Failed init
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.init(HRegionServer.java:713)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:431)
> at java.lang.Thread.run(Thread.java:619)
> 2009-06-17 11:58:55,153 [regionserver/0:0:0:0:0:0:0:0:60021] FATAL
> org.apache.hadoop.hbase.regionserver.HRegionServer: Unhandled exception.
> Aborting...
> java.io.IOException: Region server startup failed
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.convertThrowableToIOE(HRegionServer.java:832)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.init(HRegionServer.java:751)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:431)
> at java.lang.Thread.run(Thread.java:619)
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.init(HRegionServer.java:713)
> ... 2 more
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
