[
https://issues.apache.org/jira/browse/HBASE-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746174#action_12746174
]
stack commented on HBASE-1710:
------------------------------
RegExpFilter needs a class comment explaining what it does. Should talk of how
expensive this filter is (relatively).
Why not do below in constructor and be done with it?
{code}
+ if(rowRegExpPattern == null) {
+ rowRegExpPattern = Pattern.compile(rowRegExp);
+ }
{code}
Why save the String rowRegExp as data member? If you toString the Pattern,
it'll give it back to you.
Unit test? There probably was one in old code that you can steal.
Otherwise patch looks good.
> Add Regular Expression filters back into 0.20, add ability to match on KV
> -------------------------------------------------------------------------
>
> Key: HBASE-1710
> URL: https://issues.apache.org/jira/browse/HBASE-1710
> Project: Hadoop HBase
> Issue Type: New Feature
> Components: filters
> Affects Versions: 0.20.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Attachments: HBASE-1710-v1.patch
>
>
> It seems these no longer work. Should be reimplemented with new interface.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
