[ 
https://issues.apache.org/jira/browse/HBASE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748432#action_12748432
 ] 

Andrew Purtell commented on HBASE-1780:
---------------------------------------

@stack:

bq. There are a bunch of unused imports in my HTable. Are they in yours? Remove 
as part of this patch?

If you're looking at Eclipse warnings, those are due to deprecated includes 
necessary for old client API, not unused imports.

I'll fold your suggestions into the commit. Thanks for the review.



> HTable.flushCommits clears write buffer in finally clause
> ---------------------------------------------------------
>
>                 Key: HBASE-1780
>                 URL: https://issues.apache.org/jira/browse/HBASE-1780
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: client
>         Environment: All
>            Reporter: Mathias Herberts
>             Fix For: 0.20.1, 0.21.0
>
>         Attachments: HBASE-1780.patch, HBASE-1780.patch
>
>
> Metthod flushCommits clears the write buffer in a finally clause.
> When using the write buffer, if the call to processBatchOfRows done in 
> flushCommits throws an exception, the write buffer will be cleared thus 
> potentially leading to loss of data on the client side.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to