[
https://issues.apache.org/jira/browse/HBASE-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749616#action_12749616
]
stack commented on HBASE-1790:
------------------------------
The piece you pasted from HMerge looks broke to me Matus. Please add a fix to
your patch please.
In pagefilter, please just remove rather than comment-out:
{code}
- rowsAccepted = 0;
+ //rowsAccepted = 0;
{code}
You do the same commenting out elsewhere in your patch. Please just remove the
replaced code.
The StartPageFilter needs to have in its class javadoc why its different from
PageFilter. Or, better, can we not just have PageFilter do what
StartPageFilter does (pass 0 for pageStart if you want PageFilter behavior and
N if you want to do StartPageFilter actions?)
Just by way of FYI, fellas usually make the patch in the $HBASE_HOME dir.
Yours was made in $HBASE_HOME/src. ... just for the future.
Unfortunately, it seems as though this patch breaks other hbase tests. I'll
try taking a look why in a few hours.
> filters are not working correctly
> ---------------------------------
>
> Key: HBASE-1790
> URL: https://issues.apache.org/jira/browse/HBASE-1790
> Project: Hadoop HBase
> Issue Type: Bug
> Components: filters
> Affects Versions: 0.20.0, 0.21.0
> Reporter: Matus Zamborsky
> Fix For: 0.20.0
>
> Attachments: 1790-3.patch, HBASE-1790-v2.patch, hbase-1790.patch,
> testfilter.patch
>
>
> Filters used in Scanning the table are not working correctly. For example a
> table with three rows:
> 1. rowkey = adminbackslash-nb0, desc:temp = "temp"
> 2. rowkey = adminbackslash-nb1, desc:temp = "temp"
> 3. rowkey = adminkleptoman, desc:temp = "temp"
> If I scan all rows in the table without filter I get all the rows as
> expected. But applying a simple prefixfilter with parameter "adminbackslash"
> will return only first row. I searched it down to HRegion::nextInternal
> method, which will not output one passed row before denied row(by filter).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
