[ 
https://issues.apache.org/jira/browse/HBASE-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751302#action_12751302
 ] 

stack commented on HBASE-1722:
------------------------------

@Gary:

I reviewed patch for TRUNK.  Its great.  I like the addition to monitoring docs 
particularly.  Before applying, do you want to add in JMX environment variables 
to hbase-env.sh and include them in bin/hbase.sh rather than have users copy 
and paste out of the monitoring documentation?  (Default, the JMX env variables 
can be null).

Otherwise, was going to apply to TRUNK and branch so would be in 0.20.1.

Thanks.

> Add support for exporting HBase metrics via JMX
> -----------------------------------------------
>
>                 Key: HBASE-1722
>                 URL: https://issues.apache.org/jira/browse/HBASE-1722
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: ipc, master, regionserver
>    Affects Versions: 0.19.3
>            Reporter: Gary Helmling
>            Priority: Minor
>             Fix For: 0.20.1
>
>         Attachments: jmx_metrics-0.19.patch, jmx_support-trunk.patch, 
> metrics_docs_0.19.patch, metrics_docs_trunk.patch
>
>
> Current HBase metrics collection and reporting (for the 0.19 releases at 
> least) doesn't seem to export any of the metrics as MBeans via JMX.
> This patch adds JMX MBean support for reporting metrics collected in 3 areas:
> * org.apache.hadoop.hbase.ipc.HBaseRpcMetrics
> * org.apache.hadoop.hbase.master.metrics.MasterMetrics
> * org.apache.hadoop.hbase.regionserver.metrics.RegionServerMetrics
> This patch is only against the 0.19 branch, as the metrics API seems to have 
> changed a bit in Hadoop 0.20, including adding support for dynamic MBeans.  
> I'll add a patch reworked for trunk shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to