[ 
https://issues.apache.org/jira/browse/HBASE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753296#action_12753296
 ] 

stack commented on HBASE-1818:
------------------------------

@Schubert Is it possible that in the scheme of things, the compact arraycopy is 
too miniscule to show in overall PE numbers?

The v2 patch looks good.  It does not remove the section flagged above (that 
Ryan thinks might protect against a NPE). 

I'm moving this issue out of 0.20.1 and will apply to TRUNK.  Its an 
improvement.  Lets try and do bug fixes only in the branch.

> HFile code review and refinement
> --------------------------------
>
>                 Key: HBASE-1818
>                 URL: https://issues.apache.org/jira/browse/HBASE-1818
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.20.0
>            Reporter: Schubert Zhang
>            Assignee: Schubert Zhang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HFile-v1.patch, HFile-v2.patch
>
>
> HFile is a good mimic of Google's SSTable file format. And we want HFile to 
> become a common file format of hadoop in the near future.
> We will review the code of HFile and record the comments here, and then 
> provide fixed patch after the review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to