Hey Andy, Cleaning up FindBugs warnings seems to be a noble goal. Is there a plan to add FindBugs reports to the CI server for HBase in the future?
Regards, Jeff On Wed, Oct 14, 2009 at 6:41 AM, Andrew Purtell <[email protected]> wrote: > An engineering group at Trend ran FindBugs ( > http://findbugs.sourceforge.net/) on the HBase 0.20.0 release and this > static code analyis tool identified ~340 _potential_ issues. I was given > this report in a meeting and had a chance to skim some of the findings. Most > are legit. Many are Java class contract issues (equals, hashCode, etc.) > which should be cleaned up as janitorial work, some serialization contract > issues, some dead code, and, more importantly, some instances inconsistent > synchronization and a few true logic bugs. > > So I installed tonight the FindBugs plugin for Eclipse. It generates 404 > findings for the 0.20 branch, and 344 findings for trunk. > > I'm taking this opportunity to go through and make cleanups and fixes where > warranted, also addressing Eclipse warnings in the process. > > - Andy > > > __________________________________________________ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com
