[
https://issues.apache.org/jira/browse/HBASE-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767383#action_12767383
]
Jean-Daniel Cryans commented on HBASE-1886:
-------------------------------------------
I think this shouldn't be in the 0.20 branch, it's a new feature that changes
stuff directly where we are the weakest eg .META. scanner.
About the patch.
- Minor: you put the client methods in HTable instead of HBaseAdmin; the way I
see it HTable is used for gets/puts/scans but not for administrative purposes.
- I think ZKW should be refactored, your work shows it well.
- If I understand it well, your patch relies on the SyncTableAttributes called
every now and then to sync the Master internal state with what clients may have
changed in ZK. Instead, would it be better to use watchers?
Thanks for starting work on this!
> move table and column family attributes to ZK to make them live
> ---------------------------------------------------------------
>
> Key: HBASE-1886
> URL: https://issues.apache.org/jira/browse/HBASE-1886
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Fix For: 0.20.2, 0.21.0
>
> Attachments: live_attributes.patch
>
>
> This is a first cut at moving table and column family attributes up to ZK
> where they can be modified any time without requiring a disable/enable table
> cycle. Adds methods to ZooKeeperWrapper for support server side. Adds methods
> to HTableInterface for client side access. Client side talks directly to ZK.
> The new hierarchy for attributes in ZK is like:
> {noformat}
> /hbase
> /table
> /<table-name>
> /attr
> /<table-attr-name>
> /<family-name>
> /<family-attr-name>
> {noformat}
> As before attribute names and values are byte[], but now that they are hosted
> in ZK, the path delimiter ('/') cannot be used.
> Attached patch compiles but has not been tested. I put it up for a concept
> review. Next step before this is functional is to deprecate the attribute
> related methods on HTD and HCD and chase through the warnings to find all
> users who should be updated to use the ZK wrapper or new HTable methods
> instead. And, of course, then add test cases that successfully complete.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
