[
https://issues.apache.org/jira/browse/HBASE-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767505#action_12767505
]
stack commented on HBASE-1917:
------------------------------
JGray put his finger on it; 0.20 branch had code to handle old style filters.
My backport removed this code (I love unit tests).
Here's a patch which makes things pass again:
{code}
Index: src/java/org/apache/hadoop/hbase/regionserver/HRegion.java
===================================================================
--- src/java/org/apache/hadoop/hbase/regionserver/HRegion.java (revision
826758)
+++ src/java/org/apache/hadoop/hbase/regionserver/HRegion.java (working copy)
@@ -1765,7 +1765,8 @@
if (hasResults()) return true;
}
// See if current row should be filtered based on row key
- if (this.filter != null && this.filter.filterRowKey(row, 0,
row.length)) {
+ if ((this.filter != null && this.filter.filterRowKey(row, 0,
row.length)) ||
+ (oldFilter != null && this.oldFilter.filterRowKey(row, 0,
row.length))) {
readAndDumpCurrentResult();
resetFilters();
filterCurrentRow = true;
{code}
> TestScanner.testFilters failing
> -------------------------------
>
> Key: HBASE-1917
> URL: https://issues.apache.org/jira/browse/HBASE-1917
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Andrew Purtell
> Assignee: stack
> Fix For: 0.20.2
>
>
> I'm getting this on a pristine checkout of 0.20 branch:
> {noformat}
> Testcase: testStopRow took 8.382 sec
> Testcase: testFilters took 5.16 sec
> FAILED
> expected:<98> but was:<97>
> junit.framework.AssertionFailedError: expected:<98> but was:<97>
> at
> org.apache.hadoop.hbase.regionserver.TestScanner.rowPrefixFilter(TestScanner.java:157)
> at
> org.apache.hadoop.hbase.regionserver.TestScanner.testFilters(TestScanner.java:191)
> Testcase: testScanner took 4.7 sec
> Testcase: testScanAndSyncFlush took 3.527 sec
> Testcase: testScanAndRealConcurrentFlush took 2.647 sec
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
