[
https://issues.apache.org/jira/browse/HBASE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770765#action_12770765
]
stack commented on HBASE-1939:
------------------------------
This can be final:
+ private LogSyncer logSyncerThread;
Can this be static inner class? Paass in flushinterval? And the atomicboolean
close? Make it private?
+ public class LogSyncer extends Thread {
Why syncfs and not just sync? syncfs was name of the method in hdfs-200... its
now called hflush?
Do the above on commit I'd say. They are small changes. Looks good to me J-D.
> HLog group commit
> -----------------
>
> Key: HBASE-1939
> URL: https://issues.apache.org/jira/browse/HBASE-1939
> Project: Hadoop HBase
> Issue Type: New Feature
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.21.0
>
> Attachments: HBASE-1939.patch
>
>
> Currently multiple clients writing to a RS are serialized when sync'ing their
> appends. Implementing group commit can help this by being aware of all the
> clients in that queue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
