[
https://issues.apache.org/jira/browse/HBASE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786119#action_12786119
]
stack commented on HBASE-2029:
------------------------------
I like the -d addtion.
I tried the patch. It makes big difference.
When no cluster running instead of spewing zk stuff, it just does nothing
printing out a master not running on end.
Good (could be better) but way better than what was there before.
When I do a create table for an already created table, it does:
{code}
hbase(main):001:0> create 'y', 'y'
0 row(s) in 6.2210 seconds
hbase(main):002:0> create 'y', 'y'
NativeException: org.apache.hadoop.hbase.TableExistsException:
org.apache.hadoop.hbase.TableExistsException: y
at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:790)
at org.apache.hadoop.hbase.master.HMaster.createTable(HMaster.java:755)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.hbase.ipc.HBaseRPC$Server.call(HBaseRPC.java:648)
at
org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:915)
{code}
Which is better than the big page of exceptions before.
Enabling non-existent table does this:
{code}
hbase(main):007:0> enable 'xyz'
NativeException: org.apache.hadoop.hbase.TableNotFoundException:
org.apache.hadoop.hbase.TableNotFoundException: xyz
at
org.apache.hadoop.hbase.master.TableOperation$ProcessTableOperation.call(TableOperation.java:144)
at
org.apache.hadoop.hbase.master.TableOperation$ProcessTableOperation.call(TableOperation.java:73)
at
org.apache.hadoop.hbase.master.RetryableMetaOperation.doWithRetries(RetryableMetaOperation.java:67)
at
org.apache.hadoop.hbase.master.TableOperation.process(TableOperation.java:157)
at org.apache.hadoop.hbase.master.HMaster.enableTable(HMaster.java:827)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.hbase.ipc.HBaseRPC$Server.call(HBaseRPC.java:648)
at
org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:915)
{code}
With -d, its really profuse logging but its good in that its more than just
DEBUG from before printing out environment.
Will commit in a little while unless objection.
> Reduce shell exception dump on console
> --------------------------------------
>
> Key: HBASE-2029
> URL: https://issues.apache.org/jira/browse/HBASE-2029
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 0.20.2
> Reporter: Lars George
> Assignee: Jean-Daniel Cryans
> Priority: Minor
> Fix For: 0.21.0
>
> Attachments: HBASE-2029-hirb-v2.patch, HBASE-2029-hirb.patch,
> HBASE-2029.patch
>
>
> As discussed on IRC and seen over and over, the shell is too verbose when it
> prints Java related exceptions. The huge stack trace on the console is often
> causing more harm then actually helping.
> {noformat}
> ...
> [11:31pm] larsgeorge:
> the only concern is to keep it in sync with new changes and also reduce its
> stacktrace
> [11:31pm] larsgeorge:
> that can be quite nasty
> [11:31pm] _dodger_:
> I've seen a prime example of that on the mailing list today
> [11:32pm] larsgeorge:
> yeah, those do repeat themselves
> [11:32pm] larsgeorge:
> also that DEBUG is on by default
> [11:33pm] larsgeorge:
> mind you, that is a good idea for the daemons
> [11:33pm] larsgeorge:
> but prolly not the shell
> [11:33pm] jdcryans:
> I was thinking
> [11:33pm] larsgeorge:
> maybe we can set ERROR logging level just for the shell when it is started?
> [11:34pm] jdcryans:
> we should stop printing the stack trace for NSRE
> [11:34pm] larsgeorge:
> there are a few others of that sort
> [11:34pm] larsgeorge:
> be it ZK reconnects etc.
> [11:35pm] jdcryans:
> yeah there's a lot of hbase-generated zk-related noise
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
