[ 
https://issues.apache.org/jira/browse/HBASE-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791525#action_12791525
 ] 

Jean-Daniel Cryans commented on HBASE-2041:
-------------------------------------------

TestMergeTool is green on my machine, was green on Hudson after my last commit 
but then failed again... so I'm going to commit this too:

{code}
    try {
      logSyncerThread.interrupt();
      // Make sure we synced everything
      logSyncerThread.join(this.optionalFlushInterval*2);
    } catch (InterruptedException e) {
      LOG.error("Exception while waiting for syncer thread to die", e);
    }
{code}

So we will still proceed even if the thread just hangs.

> Change WAL default configuration values
> ---------------------------------------
>
>                 Key: HBASE-2041
>                 URL: https://issues.apache.org/jira/browse/HBASE-2041
>             Project: Hadoop HBase
>          Issue Type: Task
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2041-interrupt-fix.patch, HBASE-2041-shell.patch, 
> HBASE-2041.patch
>
>
> My last email on the thread "Should we change the default value of 
> hbase.regionserver.flushlogentries for 0.21?"
> {quote}
> Ok to make sure I get this right:
> - we enable deferred log flush by default
> - we set flushlogentries=1
> Also since 10 seconds is kind of a huge window I propose that:
> - we set optionalLogFlush=1000
> which is the MySQL default. We also have to update the wiki (there's
> already an entry on deferred log flush) by adding the configuration of
> flushlogentries.
> {quote}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to