[ https://issues.apache.org/jira/browse/HBASE-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795531#action_12795531 ]
stack commented on HBASE-1956: ------------------------------ Looks fine Andrew. I'd be just a little worried about all those System.currentTimeMillis calls. They add up and are inline with the write. Do you think we need to do metrics on hfile as well as hlog? Would hlog writes be sufficient canary-in-the-mine indicator that hdfs is slow? Good stuff. > Export HDFS read and write latency as a metric > ---------------------------------------------- > > Key: HBASE-1956 > URL: https://issues.apache.org/jira/browse/HBASE-1956 > Project: Hadoop HBase > Issue Type: Improvement > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Priority: Minor > Fix For: 0.20.3, 0.21.0 > > Attachments: HBASE-1956.patch > > > HDFS write latency spikes especially are an indicator of general cluster > overloading. We see this where the WAL writer complains about writes taking > > 1 second, sometimes > 4, etc. If for example the average write latency over > the monitoring period is exported as a metric, then this can feed into > alerting for or automatic provisioning of additional cluster hardware. While > we're at it, export read side metrics as well. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.