Sorry, wrong email addressee
On Tue, Jan 19, 2010 at 10:34 PM, Lars George <lars.geo...@gmail.com> wrote: > [13:32:31 r...@lv1-vs-srv-43 scripts]# java -DHOSTNAME2=lv1-xen-pdc-48 > -cp hadoop-cacti-jtg.jar com.jointhegrid.hadoopjmx.JMXToolkit -f > pdc2-cluster-jmx.properties -o hbaseRPCRegionServer -q > RpcProcessingTimeMaxTime > RpcProcessingTimeMaxTime:218361 > > [13:32:45 r...@lv1-vs-srv-43 scripts]# java -DHOSTNAME2=lv1-xen-pdc-50 > -cp hadoop-cacti-jtg.jar com.jointhegrid.hadoopjmx.JMXToolkit -f > pdc2-cluster-jmx.properties -o hbaseRPCRegionServer -q > RpcProcessingTimeMaxTime > RpcProcessingTimeMaxTime:259134 > > On Tue, Jan 19, 2010 at 10:03 PM, Lars George (JIRA) <j...@apache.org> wrote: >> >> [ >> https://issues.apache.org/jira/browse/HBASE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802469#action_12802469 >> ] >> >> Lars George commented on HBASE-2146: >> ------------------------------------ >> >> And Gary is right. >> >> There is a duplicate call in the debug! >> >> {code} >> if (LOG.isDebugEnabled()) { >> LOG.debug("Served: " + call.getMethodName() + >> " queueTime= " + qTime + >> " procesingTime= " + processingTime); >> rpcMetrics.rpcQueueTime.inc(qTime); >> rpcMetrics.rpcProcessingTime.inc(processingTime); >> } >> rpcMetrics.rpcQueueTime.inc(qTime); >> rpcMetrics.rpcProcessingTime.inc(processingTime); >> rpcMetrics.inc(call.getMethodName(), processingTime); >> {code} >> >> Also, the last line is what I could not see (forrest for the trees kind of >> thing). >> >> So we make this issue to patch the above duplicate inc and close it? >> >>> RPC related metrics are missing in 0.20.3 since recent changes >>> -------------------------------------------------------------- >>> >>> Key: HBASE-2146 >>> URL: https://issues.apache.org/jira/browse/HBASE-2146 >>> Project: Hadoop HBase >>> Issue Type: Bug >>> Affects Versions: 0.20.3 >>> Reporter: Lars George >>> Fix For: 0.20.4, 0.21.0 >>> >>> Attachments: jconsole-hbase-rpc.png, jmx-diffs.txt >>> >>> >>> Since the recent change to the Metrics setup it seems that the RPC related >>> stats have been completely dropped. See attached files for details. >> >> -- >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >> >> >
