[ 
https://issues.apache.org/jira/browse/HBASE-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802484#action_12802484
 ] 

Andrew Purtell commented on HBASE-2147:
---------------------------------------

Looks ok to me. One minor issue:

{noformat}
+  // TODO: make this more configurable?
+  private static final int TICK_TIME = 2000;
{noformat}

All-localhost deployment may need timeout longer than 40 seconds? 



> run zookeeper in the same jvm as master during non-distributed mode
> -------------------------------------------------------------------
>
>                 Key: HBASE-2147
>                 URL: https://issues.apache.org/jira/browse/HBASE-2147
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2147.patch
>
>
> this will avoid needing to 'ssh localhost' to start hbase on a stand-alone 
> non-distributed machine. We should run ZK in the same JVM and also change the 
> scripts too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to