[ https://issues.apache.org/jira/browse/HBASE-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803138#action_12803138 ]
stack commented on HBASE-1373: ------------------------------ I made hbase-2151 to add the javadoc but there are 82 warnings that need fixing before I can apply it. I took a look at this patch. There is nothing wrong with the english. Its great. The rest of the patch looks fine to me (Try and avoid white-space-only changes if you can making patches in future). I didn't test it though. Let me know when you think it ready and I will try it out. > Update Thrift to use compact/framed protocol > -------------------------------------------- > > Key: HBASE-1373 > URL: https://issues.apache.org/jira/browse/HBASE-1373 > Project: Hadoop HBase > Issue Type: Improvement > Components: thrift > Reporter: Andrew Purtell > Assignee: Lars Francke > Priority: Minor > Fix For: 0.21.0 > > Attachments: HBase-65+1373.patch, javadoc.patch > > > TCompactProtocol/TFramedTransport and nonblocking server option promises > better efficiency and performance improvements. Consider moving HBase Thrift > bits to this when full platform support is ready for TCompactProtocol. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.