clover target

[Lars George]

Hi,

in the included contrib build-contrib.xml I see these:

  <target name="clover" depends="clover.setup, clover.info"
    description="Instrument the Unit tests using Clover.  To use,
specify -Dclover.home=&lt;base of clover installation&gt;
-Drun.clover=true on the command line."/>

  <target name="clover.setup" if="clover.enabled">
    <taskdef resource="cloverlib.xml" classpath="${clover.jar}"/>
    <mkdir dir="${clover.db.dir}"/>
    <clover-setup initString="${clover.db.dir}/hbase_coverage.db">
      <fileset dir="src" includes="java/**/*"/>
    </clover-setup>
  </target>

They "cause" clover to presented for all contrib packages, like the
jmxtoolkit I am working on:

$ ant -p
Buildfile: build.xml

Main targets:

 clover             Instrument the Unit tests using Clover.  To use,
specify -Dclover.home=<base of clover installation> -Drun.clover=true
on the command line.
 create-properties  Allows to create a specifc properties file.
 jar                Compile and jar the project.
Default target: jar

I wonder if the "clover" target should also have a "if" in it, like so:

  <target name="clover" depends="clover.setup, clover.info" if="clover.enabled"
    description="Instrument the Unit tests using Clover.  To use,
specify -Dclover.home=&lt;base of clover installation&gt;
-Drun.clover=true on the command line."/>

Thoughts?

Lars