[ 
https://issues.apache.org/jira/browse/HBASE-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832624#action_12832624
 ] 

stack commented on HBASE-2211:
------------------------------

Patch looks great.

Please remove '+ * @author ferdy'.  Its apache policy to not have author 
annotations.

Also, you need to add mention of your filter to HbaseObjectWriter (If you are 
interested in the arcane why, just say and I'll dump it out in here for you).

> Add a new Filter that checks a single column value but does not emit it.
> ------------------------------------------------------------------------
>
>                 Key: HBASE-2211
>                 URL: https://issues.apache.org/jira/browse/HBASE-2211
>             Project: Hadoop HBase
>          Issue Type: New Feature
>    Affects Versions: 0.20.3
>            Reporter: Ferdy
>         Attachments: HBASE-2211-v2.patch
>
>
> Performance wise, it may be necessary for a filter to test a column for a 
> specific value (like SingleColumnValueFilter) , but exclude the KeyValue from 
> the output. This is certainly the case when the column values are large in 
> size.
> In order to keep SingleColumnValueFilter simple and maintainable, I decided 
> to subclass it. SingleColumnValueExcludeFilter is the result. Tests are 
> included.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to