[ https://issues.apache.org/jira/browse/HBASE-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans updated HBASE-2270: -------------------------------------- Attachment: HBASE-2270.patch Ryan's patch for ExplicitColumnTracker and the same idea applied to WildcardColumnTracker. > Improve how we handle recursive calls in ExplicitColumnTracker and > WildcardColumnTracker > ---------------------------------------------------------------------------------------- > > Key: HBASE-2270 > URL: https://issues.apache.org/jira/browse/HBASE-2270 > Project: Hadoop HBase > Issue Type: Improvement > Reporter: Jean-Daniel Cryans > Assignee: Jean-Daniel Cryans > Priority: Minor > Fix For: 0.20.4, 0.21.0 > > Attachments: HBASE-2270.patch > > > Ryan was saying in HBASE-2259: > {quote} > the variable 'recursive' should really be named something more accurate. the > continue at the end of the loop should get optimized out, but it looks like > bad form. also commented out code should not be in the patch, just remove it. > since this call is also tail recursive, this should be solvable with a > while(true) and return statements only, no boolean necessary. That would be a > more straightforward port, so lets do that instead. > {quote} > Let's fix ExplicitColumnTracker and WildcardColumnTracker at the same time. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.