As the author of the patch in question I unquestionably believe in it, so I give this a +1.
On Mon, Mar 8, 2010 at 7:37 PM, Jonathan Gray <jl...@streamy.com> wrote: > +1 > > JG > > -----Original Message----- > From: Dhruba Borthakur [mailto:dhr...@gmail.com] > Sent: Monday, March 08, 2010 5:59 PM > To: hbase-dev@hadoop.apache.org > Subject: Re: Any objection if we up RPC version when we go from 0.20.3 to > 0.20.4? > > +1. > > dhruba > > On Mon, Mar 8, 2010 at 5:16 PM, Kay Kay <kaykay.uni...@gmail.com> wrote: > >> not at all, considering the important fixes, we get in return. >> >> Meanwhile - it might be worthwhile to have a 'bold' mention w.r.t backward >> incompatibility ( cold restart , as opposed to a rolling one) in the >> documentation home page for 0.20.4 about this. Thanks. >> >> >> >> On 3/8/10 4:03 PM, Stack wrote: >> >>> Are there objections to changing the RPC version number when we >>> release 0.20.4? Changing the RPC version number will mean that a >>> 0.20.4 and 0.20.3 version hbase cluster will not be able to talk to >>> each other. Updating your cluster from 0.20.3 to 0.20.4 will require >>> a restart. >>> >>> Currently our RPC is brittle in that we can't add or amend methods >>> without breaking the interface. We'd like to make the interface >>> tolerant of small changes. To do this, we need to change how RPC >>> identifies remote methods. See HBASE-2219 for details. The change in >>> method identification requires that we up the RPC version so >>> mismatched clients fail fast. >>> >>> If above is amenable, we'll also pull into 0.20.4 other facility such >>> as the new multiput and fixes that make us less vulnerable to flapping >>> dns, etc. >>> >>> Yours, >>> St.Ack >>> >>> >> >> > > > -- > Connect to me at http://www.facebook.com/dhruba > >
