[
https://issues.apache.org/jira/browse/HBASE-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844987#action_12844987
]
Jean-Daniel Cryans commented on HBASE-2305:
-------------------------------------------
Some comments:
- ZK_CFG_PROPERTY + "clientPort", should be made static final
- This should really be 1 line:
{code}
+ int clientPortValue = HQuorumPeer.DEFAULT_ZOOKEPER_CLIENT_PORT;
+ zkProperties.put(clientPortKey, Integer.valueOf(clientPortValue))
{code}
- assignDefaultsForMissingProperties is a bit misleading, put all the other
missing properties in there if there's any. If not, don't create a new method
just for that.
- No need to call Integer.valueOf on ints.
Thx for looking at this Suraj!
> Client port for ZK has no default
> ---------------------------------
>
> Key: HBASE-2305
> URL: https://issues.apache.org/jira/browse/HBASE-2305
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Fix For: 0.20.4, 0.21.0
>
> Attachments: HBASE-2305.patch
>
>
> From Doug Meil on the list:
> {code}
> config.set("hbase.zookeeper.property.clientPort","2181");
> This is consistent with other references to the importance of
> "hbase.zookeeper.quorum" except that we did this testing with the intent of
> connecting using only parameters set in code to eliminate any classpath
> issues with XML files.
> FYI... If the last parameter isn't set you'll get the following error....
> could this be defaulted to a reasonable value?
> 10/03/09 10:04:55 ERROR zookeeper.ZooKeeperWrapper: no clientPort found in
> zoo.cfg
> Exception in thread "main" java.io.IOException: Could not read quorum servers
> from zoo.cfg
> at
> org.apache.hadoop.hbase.zookeeper.ZooKeeperWrapper.<init>(ZooKeeperWrapper.java:85)
> at
> org.apache.hadoop.hbase.client.HConnectionManager$ClientZKWatcher.getZooKeeperWrapper(HConnectionManager.java:223)
> at
> org.apache.hadoop.hbase.client.HConnectionManager$TableServers.getZooKeeperWrapper(HConnectionManager.java:932)
> at
> org.apache.hadoop.hbase.client.HConnectionManager$TableServers.locateRootRegion(HConnectionManager.java:948)
> at
> org.apache.hadoop.hbase.client.HConnectionManager$TableServers.locateRegion(HConnectionManager.java:625)
> {code}
> It should be easy to set it to 2181 along with the other port settings in
> HQuorumPeer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
