[
https://issues.apache.org/jira/browse/HBASE-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848541#action_12848541
]
stack commented on HBASE-2361:
------------------------------
There is an extraneous comment:
+ // Set it to the right size since we know it
Does this method need to take a NavigableMap or SortedMap:
+ public void setScopes (Map<byte[], Integer> scopes) {
... to underline you can't have a Map with a byte [] unless it sorted.
Otherwise patch looks good to me J-D.
> WALEdit broke replication scope
> -------------------------------
>
> Key: HBASE-2361
> URL: https://issues.apache.org/jira/browse/HBASE-2361
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.21.0
>
> Attachments: HBASE-2361-2.patch, HBASE-2361.patch
>
>
> Before HBASE-2283, each KV had a HLogKey with a replication scope. Now a key
> applies to a list of KVs that spans multiple families so a single scope
> doesn't work anymore. Multiple possible solutions:
> - Each KV have their own scope. We already ruled that out in a previous jira
> since that means the scope would end up in the HFiles.
> - Store pairs of scope/KV in WALEdit instead of straight KVs.
> - Have 2 parallel lists in WALEdit, one for KVs and the other for scopes.
> - Subclass KV and add the scope there, those would be created when inserted
> in the WAL and would contain the KV stored in the HFiles.
> I'm sure there are other solutions, discuss.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
