[ 
https://issues.apache.org/jira/browse/HBASE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849947#action_12849947
 ] 

Kannan Muthukkaruppan commented on HBASE-2340:
----------------------------------------------

Curious why the "flush" in the middle of the test-- coz flushing the row and 
loading the *same* rows again could mask problems with recovery. So perhaps we 
should remove the flush?

{code}
    for(int i = 0; i < 4; i++) {
      TEST_UTIL.loadTable(table, FAMILY);
      if(i == 2) {
        TEST_UTIL.flush();
      }
    }
{code}

Otherwise, the test looks good for testing log reconstruction. Perhaps you can 
commit this, and then I'll add specific cases for Puts containing multiple 
edits, Deletes, etc. (related to HBASE-2383 & HBASE-2338).

We should also enhance the test or add tests to test datanode failures-- but 
please commit this for now.








> Add end-to-end test of sync/flush
> ---------------------------------
>
>                 Key: HBASE-2340
>                 URL: https://issues.apache.org/jira/browse/HBASE-2340
>             Project: Hadoop HBase
>          Issue Type: Task
>            Reporter: stack
>            Assignee: Kannan Muthukkaruppan
>            Priority: Blocker
>             Fix For: 0.20.4, 0.21.0
>
>         Attachments: 2340-v2.patch, 2340.patch
>
>
> Add a test to do the following:
> {code}
> + Start a HBase/HDFS cluster (local node is fine).
>  + Use top-level (HTable) level APIs to put items. 
> + Try about single column puts, as well as puts which span multiple 
> columns/multiple column families, etc.
> + Then kill one region server.
> + Wait for recovery to happen.
> + And then check the rows exist.
> {code}
> Assigning myself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to