[
https://issues.apache.org/jira/browse/HBASE-2393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852507#action_12852507
]
Jean-Daniel Cryans commented on HBASE-2393:
-------------------------------------------
Thanks for the patch Bogdan, minor nits: the ThreadLocal instantiation line is
too long and it could use some comments. I will fix those on commit.
Did you do some performance testing in a multi-client environment compared to
the shipped ThriftServer?
> ThriftServer instantiates a new HTable per request
> --------------------------------------------------
>
> Key: HBASE-2393
> URL: https://issues.apache.org/jira/browse/HBASE-2393
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: thrift
> Affects Versions: 0.21.0
> Reporter: Jean-Daniel Cryans
> Assignee: Cosmin Lehene
> Fix For: 0.20.4, 0.21.0
>
> Attachments: hbase-2393.patch
>
>
> Every request creates a new HTable in ThriftServer, this is highly
> inefficient. It's even worse now that the HTable constructor does a RPC to
> the master.
> Assigning to Cosmin since he said they have some code they can share.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
