[
https://issues.apache.org/jira/browse/HBASE-2249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853716#action_12853716
]
Jean-Daniel Cryans commented on HBASE-2249:
-------------------------------------------
So I'm not sure exactly what was committed to branch WRT to the title of this
issue.
Also the flushCommit thing is broken, it added:
{code}
void testTakedown() throws IOException {
- this.table.flushCommits();
+ if (flushCommits) {
+ this.table.flushCommits();
+ }
}
{code}
This literally means that if flushCommits is false then we don't flush the
client write buffer to HBase... and this is the default value! I don't
understand how this relates to this jira as it means that we don't commit all
the rows to HBase. I discovered this while testing replication, I was missing a
few thousand rows and asked Ryan to run it when he told me you have the right
number only when you run PE with --flushCommits. This should be reverted until
fixed.
> The PerformanceEvaluation read tests don't take the MemStore into account.
> --------------------------------------------------------------------------
>
> Key: HBASE-2249
> URL: https://issues.apache.org/jira/browse/HBASE-2249
> Project: Hadoop HBase
> Issue Type: Improvement
> Affects Versions: 0.20.3
> Reporter: Dan Washusen
> Fix For: 0.20.4
>
> Attachments: 2249-TRUNK.patch, HBASE-2249.patch
>
>
> The write tests in the PerformanceEvaluation flush the MemStore after they
> complete, as a result the read tests don't take the MemStore into account
> (because it's always empty). An optional flag could be provided when the
> performance evaluation starts that dictates if the table should be flushed
> after a test completes. This optional flag would allow changes to the
> MemStore to be performance tested...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
