[
https://issues.apache.org/jira/browse/HBASE-2421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857841#action_12857841
]
Todd Lipcon commented on HBASE-2421:
------------------------------------
+ server.shutdownHDFS.set(false); // no, bad.
Can you add a setter to HRegionServer rather than making this public? That
comment also should be made more explanatory - not clear what's going on there.
+ if (singletonList) {
+ if (singleRowCause != null)
+ throw new IOException(singleRowCause);
+ }
I missed this when looking over your shoulder, but I think this if needs to go
inside the following if (!list.isEmpty()) block. Otherwise if we have a
retryable exception for a single-row get, then succeed on the second try, we'll
still throw the exception from the first try. Alternatively, instead of moving
the if, you could reset singleRowCause at the top of each inner loop.
- should augment javadoc to explain what happens in case of exceptions
> Put hangs for 10 retries on failed region servers
> -------------------------------------------------
>
> Key: HBASE-2421
> URL: https://issues.apache.org/jira/browse/HBASE-2421
> Project: Hadoop HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: ryan rawson
> Priority: Critical
> Fix For: 0.20.5, 0.21.0
>
> Attachments: HBASE-2421-2.txt, HBASE-2421.txt
>
>
> Since MultiPut got in, instead of calling getRegionLocationForRowWithRetries
> we now call getRegionServerWithRetries to send an array list of Puts. The
> problem is that if the region server failed, we'll still retry the 10 times
> in a backoff fashion even tho we get connections refused. This is also true
> for a single put since it's the same code path.
> Marking as critical since it almost disables our responsiveness to machine
> failures in certain cases where we are already sending a batch of edits when
> the server fails. Assigning to Ryan since he's been there recently.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
