> On 2011-07-22 18:01:31, Ashutosh Chauhan wrote: > > trunk/src/test/org/apache/hcatalog/pig/TestHCatStorer.java, line 589 > > <https://reviews.apache.org/r/1184/diff/1/?file=26864#file26864line589> > > > > In all of these test cases, you should also assert metadata, by > > retrieving them from metastore and verifying as you are expecting them.
Hmm... the metadata isn't affected as much by this patch as much as the presence of it at all - if a read succeeds, the metadata is in order. That would be tested more by add_partitions() tests than by dynamic publish tests. But yes, you're right in that we should add in more explicit test coverage, we can open another jira for that - that's across the board - Sushanth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1184/#review1167 ----------------------------------------------------------- On 2011-07-22 16:09:41, Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1184/ > ----------------------------------------------------------- > > (Updated 2011-07-22 16:09:41) > > > Review request for hcatalog. > > > Summary > ------- > > HCatalog-42 review request on behalf of Sushanth > > > This addresses bug HCATALOG-42. > https://issues.apache.org/jira/browse/HCATALOG-42 > > > Diffs > ----- > > trunk/build.xml 1149353 > trunk/src/java/org/apache/hcatalog/common/ErrorType.java 1149353 > trunk/src/java/org/apache/hcatalog/common/HCatConstants.java 1149353 > trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1149353 > trunk/src/java/org/apache/hcatalog/har/HarOutputCommitterPostProcessor.java > PRE-CREATION > trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputCommitter.java > 1149353 > trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java > 1149353 > trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java > 1149353 > trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java > 1149353 > trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputCommitter.java > 1149353 > > trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputCommitterPostProcessor.java > PRE-CREATION > trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 1149353 > trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputStorageDriver.java > 1149353 > trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordWriter.java 1149353 > trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java 1149353 > trunk/src/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java 1149353 > trunk/src/java/org/apache/hcatalog/pig/HCatEximStorer.java 1149353 > trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1149353 > trunk/src/java/org/apache/hcatalog/pig/PigHCatUtil.java 1149353 > trunk/src/java/org/apache/hcatalog/rcfile/RCFileMapReduceOutputFormat.java > 1149353 > trunk/src/java/org/apache/hcatalog/rcfile/RCFileOutputDriver.java 1149353 > trunk/src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java 1149353 > > trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java > PRE-CREATION > trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatEximInputFormat.java > 1149353 > trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatEximOutputFormat.java > 1149353 > trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatNonPartitioned.java > 1149353 > trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java > 1149353 > trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatPartitioned.java > 1149353 > trunk/src/test/org/apache/hcatalog/pig/TestHCatStorer.java 1149353 > > Diff: https://reviews.apache.org/r/1184/diff > > > Testing > ------- > > Unit tests are included > > > Thanks, > > Ashutosh > >
