[
https://issues.apache.org/jira/browse/HCATALOG-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071419#comment-13071419
]
jirapos...@reviews.apache.org commented on HCATALOG-64:
-------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1197/
-----------------------------------------------------------
(Updated 2011-07-26 23:11:17.314875)
Review request for hcatalog and Sushanth Sowmyan.
Changes
-------
(updating to latest patch)
Summary
-------
Hcatalog-64 review request on behalf of Francis.
This addresses bug HCATALOG-64.
https://issues.apache.org/jira/browse/HCATALOG-64
Diffs (updated)
-----
/trunk/src/java/org/apache/hcatalog/common/HCatUtil.java 1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseInputFormat.java
1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatBaseOutputFormat.java
1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximInputFormat.java
1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximOutputCommitter.java
1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatEximOutputFormat.java
1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatInputFormat.java 1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputCommitter.java
1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatOutputFormat.java 1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatRecordWriter.java 1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/HCatTableInfo.java 1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/InitializeInput.java 1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/InputJobInfo.java PRE-CREATION
/trunk/src/java/org/apache/hcatalog/mapreduce/JobInfo.java 1151189
/trunk/src/java/org/apache/hcatalog/mapreduce/OutputJobInfo.java 1151189
/trunk/src/java/org/apache/hcatalog/pig/HCatLoader.java 1151189
/trunk/src/java/org/apache/hcatalog/pig/HCatStorer.java 1151189
/trunk/src/java/org/apache/hcatalog/rcfile/RCFileInputDriver.java 1151189
/trunk/src/test/org/apache/hcatalog/listener/TestNotificationListener.java
1151189
/trunk/src/test/org/apache/hcatalog/mapreduce/HCatMapReduceTest.java 1151189
/trunk/src/test/org/apache/hcatalog/mapreduce/TestHCatOutputFormat.java
1151189
Diff: https://reviews.apache.org/r/1197/diff
Testing
-------
Thanks,
Sushanth
> Refactor HCatTableInfo, JobInfo and OutputJobInfo
> -------------------------------------------------
>
> Key: HCATALOG-64
> URL: https://issues.apache.org/jira/browse/HCATALOG-64
> Project: HCatalog
> Issue Type: Improvement
> Reporter: Francis Liu
> Assignee: Francis Liu
> Attachments: HCatTableInfo_JobInfo_OutputJobInfo_3.patch
>
>
> These classes and their roles has become convoluted. HCatTableInfo should be
> an HCat abstraction of table and thus not have any job specific information
> and should not contain different information depending on usage. *JobInfo
> classes should contain job specific information (user provided, derived from
> metastore info, etc). Since *JobInfo contains such information it should be
> the object which is passed to HCatInputFormat.setInput and
> HCatInputFormat.setOutput. Also JobInfo should be renamed to InputJobInfo for
> consistency and clarity. Also there needs to be a way to pass implementation
> specific configuration information down to the actual storage driver.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
