[ 
https://issues.apache.org/jira/browse/HCATALOG-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083343#comment-13083343
 ] 

Sushanth Sowmyan commented on HCATALOG-79:
------------------------------------------

The har code-flow is interleaved inside HCatOutputFormat, HCatOutputCommitter, 
HCatRecordWriter - they each instantiate and pick up HiveConf currently without 
a way to insert/inject parameters or overrides. That is a very much needed 
feature that will allow us to test for things like this. As of right now, 
without that ability, I cannot set those parameters explicitly in unit tests.

I retract what I said about needing to inject into hive-site.xml - that is 
unnecessary. What we need is a way to inject that into the HiveConf that is 
instantiated by HCatOutputFormat, and/or a way to pass in a pre-constructed 
HiveConf into HCatOutputFormat.

> Add ERROR_MOVE_FAILED into expected exception types for 
> TestHCatDynamicPartitioned's duplicate partition publish test
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HCATALOG-79
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-79
>             Project: HCatalog
>          Issue Type: Bug
>    Affects Versions: 0.2
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>            Priority: Trivial
>         Attachments: HCATALOG-79.patch
>
>
> In cases with har, ErrorType.ERROR_MOVE_FAILED is also a possible way for the 
> duplicate publish test to fail out, needs to be added to expected failure 
> modes. We don't hit this by default in our unit test cases because our 
> default settings run with har disabled.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to