[ 
https://issues.apache.org/jira/browse/HCATALOG-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088028#comment-13088028
 ] 

Sushanth Sowmyan commented on HCATALOG-64:
------------------------------------------

Ok, +1-ing the properties addition as per previous discussions.

Have updated the reviewboard with a svn diff generated from the above git diff 
too : Diff from previous diff is available at 
https://reviews.apache.org/r/1197/diff/2-3/#index_header

(I was half-wondering why we didn't have a way to set properties, but it seems 
like it might be used by using getProperties(), which does return a mutable 
Properties object and then setting what the user wanted in that via put(). I 
don't veer one way or the other stylistically on that unless anyone else has 
any concerns - I know we have a few other cases that are similar.)

> Refactor HCatTableInfo, JobInfo and OutputJobInfo
> -------------------------------------------------
>
>                 Key: HCATALOG-64
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-64
>             Project: HCatalog
>          Issue Type: Improvement
>    Affects Versions: 0.1, 0.2
>            Reporter: Francis Liu
>            Assignee: Francis Liu
>             Fix For: 0.2
>
>         Attachments: HCatalog-64_git_diff.patch
>
>
> These classes and their roles has become convoluted. HCatTableInfo should be 
> an HCat abstraction of table and thus not have any job specific information 
> and should not contain different information depending on usage. *JobInfo 
> classes should contain job specific information (user provided, derived from 
> metastore info, etc). Since *JobInfo contains such information it should be 
> the object which is passed to HCatInputFormat.setInput and 
> HCatInputFormat.setOutput. Also JobInfo should be renamed to InputJobInfo for 
> consistency and clarity. Also there needs to be a way to pass implementation 
> specific configuration information down to the actual storage driver.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to