[ 
https://issues.apache.org/jira/browse/HCATALOG-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143578#comment-13143578
 ] 

Sushanth Sowmyan commented on HCATALOG-145:
-------------------------------------------

Code looks mostly okay, but I currently don't yet have the hive patch that adds 
BINARY support there, so tests are still failing. I think progressing the hive 
svn branch to include that is necessary for us to commit this patch. If that 
happens and the test succeeds, I can +1.

One other thing - you've changed a if-structure in HCatUtil.extractPigObject to 
a case-structure. That's a good change, but that resulted in bad indents for 
that structure - could you also fix that?

Thanks!

                
> Add support for binary data type
> --------------------------------
>
>                 Key: HCATALOG-145
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-145
>             Project: HCatalog
>          Issue Type: New Feature
>    Affects Versions: 0.3
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>             Fix For: 0.3
>
>         Attachments: hcat-145.patch, hcat-145.patch
>
>
> Hive added support for binary data type via HIVE-2380, Pig already supports 
> bytearray. HCatalog should support binary type as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to