[
https://issues.apache.org/jira/browse/HCATALOG-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144243#comment-13144243
]
jirapos...@reviews.apache.org commented on HCATALOG-154:
--------------------------------------------------------
bq. On 2011-11-04 18:26:48, David Capwell wrote:
bq. > Can we have a test added that tests this change?
Do you mean test that the correct outputdirectory is being used?
bq. On 2011-11-04 18:26:48, David Capwell wrote:
bq. >
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseOutputStorageDriver.java,
line 55
bq. > <https://reviews.apache.org/r/2727/diff/1/?file=56379#file56379line55>
bq. >
bq. > When do we change the output location to match the driver?
bq. > Why not have output storage driver have another init method that
gets called from HCatOutputformat.setOutput?
We are not trying to re-architect the driver interface here. There's already a
separate effort for that. We'll update the driver when it comes to that.
bq. On 2011-11-04 18:26:48, David Capwell wrote:
bq. >
storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java,
line 448
bq. > <https://reviews.apache.org/r/2727/diff/1/?file=56380#file56380line448>
bq. >
bq. > My MR job should work with RCFiles and with HBase, the output Key
should be WritableComparible and value should be DefaultHCatRecord
This is a different bug which I will address in a separate jira having to do
with a bug with SequenceFile and HBaseBulkOutputFormat.
- Francis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2727/#review3051
-----------------------------------------------------------
On 2011-11-04 17:44:01, Francis Liu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2727/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-04 17:44:01)
bq.
bq.
bq. Review request for hcatalog, Vandana Ayyalasomayajula and David Capwell.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. fixed race condition and moved resolution outside of getOutputLocation
since output is intermediate.
bq.
bq.
bq. This addresses bug hcatalog-154.
bq. https://issues.apache.org/jira/browse/hcatalog-154
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java
989286f
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputStorageDriver.java
9dfd238
bq.
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseOutputStorageDriver.java
19ddd28
bq.
storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java
c25e56d
bq.
bq. Diff: https://reviews.apache.org/r/2727/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. all unit tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Francis
bq.
bq.
> HBase bulkOSD and directOSD return inconsistent path for getOutputLocation()
> ----------------------------------------------------------------------------
>
> Key: HCATALOG-154
> URL: https://issues.apache.org/jira/browse/HCATALOG-154
> Project: HCatalog
> Issue Type: Bug
> Components: hbase
> Affects Versions: 0.3
> Reporter: David Capwell
> Assignee: Francis Liu
> Labels: hbase
> Fix For: 0.3
>
> Attachments: HCATALOG-154.patch
>
>
> org.apache.hcatalog.common.HCatException : 2001 : Error setting output
> information. Cause : java.io.IOException: bulkOSD and directOSD return
> inconsistent path for getOutputLocation()
> at
> org.apache.hcatalog.mapreduce.HCatOutputFormat.setOutput(HCatOutputFormat.java:257)
> ...
> at java.lang.Thread.run(Thread.java:619)
> Caused by: java.io.IOException: bulkOSD and directOSD return inconsistent
> path for getOutputLocation()
> at
> org.apache.hcatalog.hbase.HBaseOutputStorageDriver.getOutputLocation(HBaseOutputStorageDriver.java:52)
> at
> org.apache.hcatalog.mapreduce.HCatOutputFormat.setOutput(HCatOutputFormat.java:155)
> ... 24 more
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
