> On 2011-11-10 00:51:22, David Capwell wrote: > > Is this dependent on https://issues.apache.org/jira/browse/HCATALOG-154 ? > > I see that some of the changes to the test are there as well.
yep, tho the diff should only reflect this patch. I made the jiras dependent of each other in case someone decides to apply the patch. - Francis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2795/#review3144 ----------------------------------------------------------- On 2011-11-10 00:39:35, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2795/ > ----------------------------------------------------------- > > (Updated 2011-11-10 00:39:35) > > > Review request for hcatalog, Sushanth Sowmyan, Vandana Ayyalasomayajula, and > David Capwell. > > > Summary > ------- > > HBaseStorageHandler creates hbase table names with <db_name>.<table_name> > when db used is not default, fixed that problem. updated and refactored bulk > tests. > > > This addresses bug HCatalog-157. > https://issues.apache.org/jira/browse/HCatalog-157 > > > Diffs > ----- > > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBaseOutputStorageDriver.java > 989286f > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java > c25e56d > > Diff: https://reviews.apache.org/r/2795/diff > > > Testing > ------- > > added a new test, all tests passed > > > Thanks, > > Francis > >
