[ 
https://issues.apache.org/jira/browse/HCATALOG-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148117#comment-13148117
 ] 

[email protected] commented on HCATALOG-155:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2799/#review3163
-----------------------------------------------------------



storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputFormat.java
<https://reviews.apache.org/r/2799/#comment6985>

    Rather than Object it should be Writable since that is the interface it is 
expecting



storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java
<https://reviews.apache.org/r/2799/#comment6986>

    Can you change this to WritableComparable and still have the test pass?  
Users should be able to work with <WritableComparable, HCatRecord>



storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java
<https://reviews.apache.org/r/2799/#comment6987>

    Why BytesWritable, does it matter whats here?


- David


On 2011-11-10 19:50:20, Francis Liu wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2799/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-10 19:50:20)
bq.  
bq.  
bq.  Review request for hcatalog, Sushanth Sowmyan, Vandana Ayyalasomayajula, 
and David Capwell.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Patch fixes errors thrown by explicit type checks made by SequenceFile 
output format. I've updated both direct and bulk unit tests as well.
bq.  
bq.  
bq.  This addresses bug HCATALOG-155.
bq.      https://issues.apache.org/jira/browse/HCATALOG-155
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputFormat.java
 5165f7f 
bq.    
storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java
 c25e56d 
bq.    
storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputStorageDriver.java
 d612584 
bq.  
bq.  Diff: https://reviews.apache.org/r/2799/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  updated tests should verify things are working as should.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Francis
bq.  
bq.


                
> HBase bulkOSD requires value to be Put rather than HCatRecord
> -------------------------------------------------------------
>
>                 Key: HCATALOG-155
>                 URL: https://issues.apache.org/jira/browse/HCATALOG-155
>             Project: HCatalog
>          Issue Type: Bug
>          Components: hbase
>    Affects Versions: 0.3
>            Reporter: David Capwell
>            Assignee: Francis Liu
>              Labels: hbase
>             Fix For: 0.3
>
>         Attachments: HCATALOG-155.patch
>
>
> So I tried running a MR job writing to hcat+hbase and get the following error:
> [INFO] 02:42:47,857 [pool-1-thread-1] JobClient:1287 - Task Id : 
> attempt_201111040030_0023_r_000000_0, Status : FAILED
> java.io.IOException: wrong value class: org.apache.hadoop.hbase.client.Put is 
> not class org.apache.hcatalog.data.DefaultHCatRecord
>        at 
> org.apache.hadoop.io.SequenceFile$Writer.append(SequenceFile.java:988)
>        at 
> org.apache.hadoop.mapreduce.lib.output.SequenceFileOutputFormat$1.write(SequenceFileOutputFormat.java:74)
>        at 
> org.apache.hcatalog.mapreduce.DefaultRecordWriterContainer.write(DefaultRecordWriterContainer.java:64)
>        at 
> org.apache.hcatalog.mapreduce.DefaultRecordWriterContainer.write(DefaultRecordWriterContainer.java:33)
>        at 
> org.apache.hadoop.mapred.ReduceTask$NewTrackingRecordWriter.write(ReduceTask.java:587)
>        at 
> org.apache.hadoop.mapreduce.TaskInputOutputContext.write(TaskInputOutputContext.java:80)
> It looks like my key has to be ImmutableBytesWritable.class and my value must 
> be Put.class?  Shouldn't my key be WritableComparible and value 
> DefaultHCatRecord (HCatRecord)?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to