> On 2011-11-10 23:37:00, David Capwell wrote: > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputFormat.java, > > lines 42-43 > > <https://reviews.apache.org/r/2799/diff/1/?file=57429#file57429line42> > > > > Rather than Object it should be Writable since that is the interface it > > is expecting
It doesn't really matter in this case. If we want to really be thorough it should be ImmutableBytesWritable and Put since it's the only accepted classes by the SequenceFile. > On 2011-11-10 23:37:00, David Capwell wrote: > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java, > > line 315 > > <https://reviews.apache.org/r/2799/diff/1/?file=57430#file57430line315> > > > > Why BytesWritable, does it matter whats here? I wanted to test wether we are successfully ignoring the key, since internally we are passing an empty ImmutableBytesWritable. If BytesWritable was being passed we'd get an exception. > On 2011-11-10 23:37:00, David Capwell wrote: > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java, > > line 146 > > <https://reviews.apache.org/r/2799/diff/1/?file=57430#file57430line146> > > > > Can you change this to WritableComparable and still have the test pass? > > Users should be able to work with <WritableComparable, HCatRecord> Yes it will. As line #312 proves we ignore the keys any restrictions imposed on the type of keys is enforced by HCatOutputFormat and containers in which should be tested in the core module. - Francis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2799/#review3163 ----------------------------------------------------------- On 2011-11-10 19:50:20, Francis Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2799/ > ----------------------------------------------------------- > > (Updated 2011-11-10 19:50:20) > > > Review request for hcatalog, Sushanth Sowmyan, Vandana Ayyalasomayajula, and > David Capwell. > > > Summary > ------- > > Patch fixes errors thrown by explicit type checks made by SequenceFile output > format. I've updated both direct and bulk unit tests as well. > > > This addresses bug HCATALOG-155. > https://issues.apache.org/jira/browse/HCATALOG-155 > > > Diffs > ----- > > > storage-drivers/hbase/src/java/org/apache/hcatalog/hbase/HBaseBulkOutputFormat.java > 5165f7f > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseBulkOutputStorageDriver.java > c25e56d > > storage-drivers/hbase/src/test/org/apache/hcatalog/hbase/TestHBaseDirectOutputStorageDriver.java > d612584 > > Diff: https://reviews.apache.org/r/2799/diff > > > Testing > ------- > > updated tests should verify things are working as should. > > > Thanks, > > Francis > >
